rails-composer icon indicating copy to clipboard operation
rails-composer copied to clipboard

Sass is breaking on @extend “.bg-faded”

Open obromios opened this issue 7 years ago • 4 comments

On using rails-composer, with the rails-devise-pundit option, I had the following error

Sass::SyntaxError - ".authform form" failed to @extend ".bg-faded".
The selector ".bg-faded" was not found.
Use "@extend .bg-faded !optional" if the extend should be able to fail.

This was fixed using this SO answer. However, I do not understand why it happened in the first place.

Chris

obromios avatar Nov 21 '17 08:11 obromios

change @extend .bg-faded; to @extend .bg-light;

answer found here

golddiga avatar Feb 08 '18 09:02 golddiga

goldiga, the answer you refer to is the same one I cite in my question. The issue is why is rails-composer generating code that needs to be manually fixed.

obromios avatar Feb 08 '18 20:02 obromios

The .bg-faded was changed to .bg-light in Bootstrap v4 Beta 1 in July 2017. I haven't been tracking the changes in Bootstrap v4 (I'm not using Bootstrap v4) which is why Rails Composer was generating code that had to be manually fixed (with later versions of Bootstrap). Thanks for catching this and bringing it to my attention. I've updated the rails_layout gem to fix this.

You can check if this is resolved now but I am getting errors building the rails-devise-pundit example application with Rails 5.2 and Ruby 2.5. Probably some more issues to report if you can identify them.

DanielKehoe avatar Feb 09 '18 11:02 DanielKehoe

Thank you.

obromios avatar Feb 10 '18 00:02 obromios