Rails icon indicating copy to clipboard operation
Rails copied to clipboard

Refactor class PublicCompany

Open madoar opened this issue 8 years ago • 2 comments

I've stumbled over the class PublicCompany. This class is over 2000 lines long, therefore I suggest to divide it in multiple classes if possible. This is especially important in the context of #41, because PublicCompany is one of the classes that need to be persisted/saved, therefore it would be possible to split it into smaller chunks with less fields.

madoar avatar Jul 22 '17 19:07 madoar

PublicCompany is not persisted, only actions are. I don't see a compelling reason to split it (and I have no clue how this could be done). MIght be an idea for Rails 3.0.

erik-vos avatar Jul 22 '17 19:07 erik-vos

I kind of fear that PublicCompany is a god class, with too much functionality. Therefore I would suggest to split it up. This would make the class easier to understand too.

madoar avatar Jul 22 '17 19:07 madoar