keystone.guru icon indicating copy to clipboard operation
keystone.guru copied to clipboard

Published 20 hours ago • verified publisher icon RaiderIO

In edit mode - selecting pulls can be difficult

Open Wotuu opened this issue 3 years ago • 7 comments

I got mentioned by Kognos that this is an issue. He sent me a video detailing the issue, he uses the sidebar to switch pulls but it visibly does not want to cooperate about 50% of the time.

Wotuu avatar Mar 09 '21 20:03 Wotuu

to provide some more information on this issue, I have run into it a lot myself since I started using the site. It seems to only happen on my mac, and when I "click" a pull you very briefly (a few frames) get the animation for dragging a pull to change pull order. If, on my Mac I click as fast as I can, it will switch pulls properly. I tried covering the sensor with some opaque tape to see if it was related to movement, but it doesn't seem to be. I would describe it as going into click and hold mode MUCH too quickly. I am not a dev, so I am not sure where or what to look at in the code.

merriry avatar Mar 19 '21 16:03 merriry

Thanks for the additional info. I didn't look into this further but perhaps the library that I use for the drag and drop has some options to prevent this sort of behaviour. I'll try to see if I have some time tonight to look into this again.

Wotuu avatar Mar 20 '21 17:03 Wotuu

I just took a look at it (sorry it took so long) and I believe I have fixed it. Is currently available in the redesign site. I will very soon allow everyone to opt-in on the redesign so that they can get this fix automatically.

Wotuu avatar Apr 03 '21 20:04 Wotuu

What ended up being the issue?

merriry avatar Apr 03 '21 20:04 merriry

So it was quite simple, I don't know why but Firefox required a delay between clicking and the actual drag action for it to work properly. So if you look very closely if you try to drag right now there will be a 100ms delay in being able to drag the pull. You will not really notice this as you use the feature, but it prevents the issue where just one click and it will think you're dragging it. Chrome didn't have this issue.

This commit eventually resolved it. https://github.com/Wotuu/keystone.guru/commit/e9d23d121172038f716cc7a8358aa0e079d82311

Wotuu avatar Apr 06 '21 08:04 Wotuu

Issue seems to be back when pressing the buttons in Firefox - Chrome is ok: https://discord.com/channels/482454450754289675/482822434106638346/904946804842446869

Wotuu avatar Nov 02 '21 10:11 Wotuu

Bump

Wotuu avatar Apr 30 '22 15:04 Wotuu

The issue is also resolved in firefox now. You can close this I think.

omicron-o avatar Dec 26 '22 15:12 omicron-o