Mattia Tommasone

Results 145 comments of Mattia Tommasone

Yes I'd like to have the sponsors buttons on the website as well

I have nothing against it: in fact, it seems like a good feature addition to me 👍 I'd gladly review a PR about it and the implementation doesn't even seem...

The ProxyWeakReferenceTest is indeed stressing the memory to verify that there are no leaks; it surprises me that upgrading dependencies makes it throw OOME. I suggest adding `-XX:+HeapDumpOnOutOfMemoryError` to the...

Can you please rebase on top of master and retry? I _think_ I found the cause of the memory leak spotted by `ProxyWeakReferenceTest` and fixed it.

...nevermind, that didn't work. I'll keep looking into a fix.

> How should we proceed with the JUnit 6 dependency? Options: > > * Revert to JUnit 5.14.1 to maintain current Java and Kotlin baseline compatibility > * Continue with...

That's correct, injecting mocks as a list instead of one by one is not supported at the moment. I'd gladly review a PR to add this feature, though.

@ianbrandt , can you please rebase on top of the master branch? I should have fixed the build failure.

Thanks for this! I like the test coverage particularly. I agree the KDoc and comments in ValueClassSupport.kt are a bit too much, can you clean them up a bit?