gpu_poor icon indicating copy to clipboard operation
gpu_poor copied to clipboard

What's the meaning of magic numbers?

Open flei2019 opened this issue 1 year ago • 0 comments

Hi, thanks for your great work to calculate Tokens/s. I read your code of App.js and found some magic numbers. Can you please add comments for them? Just list out some numbers as below. It is awesome you would add comments for all magic numbers.

  1.     let finalPromptTime =
         theoryTimePrompt_in_ms * getFloatRatio_F16(quantType) * 1.8 +  // What's the meaning of ”1.8“?
         convertByteToMB(2 * memoryTransfer) * (0.008 / 100);           // What's the meaning of "0.008 / 100" ?
    
  2. What's the meaning of extraFactor 2.0,1.5,1.0 ...?

flei2019 avatar Jan 16 '24 01:01 flei2019