Rahix

> > But I wonder about the impl of the new [I2c::transaction](https://docs.rs/embedded-hal/latest/embedded_hal/i2c/trait.I2c.html#tymethod.transaction). The contract defined upstream does not forbid empty data buffers. So we could potentially hit the same illegal...

Please at least put in the effort to write a proper description of what problem you are having and what you already attempted. Otherwise others won't put in the effort...

Yeah, the `val_0x##()` names are placeholders used by Atmel. We patch these manually and should probably also do it for this one. The [README](https://github.com/Rahix/avr-device/blob/main/README.md#adding-a-new-chip) describes where patches are added. Here...

Yeah the issue you linked to is exactly it. We have to do similar patches for ATmega328P then. Also see the PR linked to that issue: https://github.com/Rahix/avr-device/pull/131 If you need...

> but my suggestion is to drop them entirely Ah, only now saw this. Fair enough, made this change non-optional.

Ping @EmperorArthur :)

Agreed. I don't have a Windows system to check with so I rely on feedback from users on what works. If the current instructions have problems, please send a PR...

Blocked on #585 due to this (seen in CI): ```text error: rustc 1.79.0-nightly is not supported by the following package: [email protected] requires rustc 1.81 ```

Yeah, this was also discussed a bit in #52 back then. I am in favor of this change and I don't see any problems. My only comment would be that...

> Therefore I personally think it should be non-optional with a deprecation-period with a warning for the fn() type. I am not entirely happy with this, but I see your...