clapper icon indicating copy to clipboard operation
clapper copied to clipboard

Crash when opening both video and external subtitles at once

Open axel358 opened this issue 2 years ago • 4 comments

Clapper doesn't automatically load external subtitles for videos. I haven't find any GUI option to to this manually. And passing the subtitles with the video from the Open with menu of the file manager results in a crash

axel358 avatar Mar 15 '22 10:03 axel358

Clapper doesn't automatically load external subtitles for videos.

This would not go through files portal, making it impossible to work in packages like Flatpak. Files need to be manually opened via either file manager or open files dialog for portal to work. Also an app that browses, opens and reads some user files (and does who knows what with them) without user knowledge seems like a bad idea.

And passing the subtitles with the video from the Open with menu of the file manager results in a crash

There is a known problem with opening both at once (something that was intended to work), I hope to have this fixed along with major code rework for next Clapper version.

For the time being, opening video alone (either from file manager or open files dialog) and then after playback starts, launching open files dialog again and opening subtitles file alone this time should work.

Rafostar avatar Mar 15 '22 10:03 Rafostar

Any way to do this automatically when running unsanboxed?, I don't really care for Flatpak, i prefer usability over "security", i don't need to be protected from open source applications. Also on that same line an option to automatically add files on the same folder to the playlist when opening a file from the file manager. I understand if this doesn't align with your vision for the project.

axel358 avatar Mar 15 '22 12:03 axel358

Any way to do this automatically when running unsanboxed?

Not counting security, I would rather avoid situations where some features only work in a specific package. App should aim to work the same no matter if it is sandboxed or not. Once current racy behavior of opening video+subs at once is fixed, it should be as easy as selecting both at once. This also allows to select both (and thus open) or not (play without) subtitles in said folder, so it has an additional benefit to it.

Also on that same line an option to automatically add files on the same folder to the playlist when opening a file from the file manager.

You can select multiple videos at once, right click and select "Open with Clapper". Selected files are appended to the playlist. And once again this gives the benefit of selecting only some media in current folder for your "today's playlist" rather then everything always. This works even now.

Rafostar avatar Mar 15 '22 12:03 Rafostar

Alright, thanks for your reply. Keep up the great work u're doing with Clapper :)

axel358 avatar Mar 15 '22 12:03 axel358