clapper icon indicating copy to clipboard operation
clapper copied to clipboard

Restore previous subtitles when resuming video

Open CristianKerr opened this issue 2 years ago • 6 comments

Hi, first of all I would like to tell you that this app is great! I wanted to ask for some subs improvement.

  1. When there are subtitles in the same folder with the same name as the vid, it would be nice if the player detected and loaded them automatically. (same way e.g. Haruno player or VLC)
  2. When re-opening and resuming the movie, the subs are not loaded even if I loaded them previously.
  3. Multiple subtitles selection, for simplicity sake, it would be nice to have one more quick menu (button) where I could change subs quickly. Sometimes I download 4-5 subs files to find whichever works best and quick swich is in that case really important for non-english users I'd say. I can give you Haruno as example. Part of new issue - #109 .

CristianKerr avatar Jul 20 '21 07:07 CristianKerr

  1. Player can technically (I say technically cause its still not working properly yet) open both video and subtitles when you select both from file manager (or file chooser). Otherwise it would require giving Flatpak version full host file system access, which is something, well... dangerous?
  2. Opening a recent file including previously loaded subtitles is a very good idea, but we need a recent played videos view with database first. Requires implementing #60 first.
  3. We have multiple subtitles selection for build-in subtitles, but what you want is similar thing for external ones, or did I misunderstood?

Rafostar avatar Jul 20 '21 08:07 Rafostar

  1. Aha, so it means that in non Flatpak version the autoload works?
  2. ok
  3. yes, you understood well. Thanks you for the answer and consideration :)

CristianKerr avatar Jul 20 '21 10:07 CristianKerr

Aha, so it means that in non Flatpak version the autoload works?

Some other apps on Flathub have filesystem=host permissions by default, but I would rather not do that, cause whats the point of container if it has full filesystem rw access? Also an app that can freely read/write host files and has network access, does not sound safe. I would rather not do that.

Selecting and opening both video and subtitles at once or D&D subs into player window should be better and safer alternatives.

Rafostar avatar Jul 20 '21 10:07 Rafostar

@CristianKerr

Can you open "multiple external subtitles" as a separate issue/feature request? Its easier for me to track progress this way as this does not depend on auto loading subtitles.

Rafostar avatar Jul 20 '21 11:07 Rafostar

Sure.

CristianKerr avatar Jul 20 '21 14:07 CristianKerr

Note to self: To make sure this works with Flatpak, its gonna need storing a copy of subtitles file in cache directory. Otherwise we will not have an automatic access to that file on next startup. In such case we are gonna need ability to store up to few "recent" videos data in database and paths to their corresponding subtitles.

Rafostar avatar May 10 '22 11:05 Rafostar