Raphaël Vinot

Results 550 comments of Raphaël Vinot

Hi! Yes, I'm using it with redis-py 5.0.8 and it works perfectly fine, but I might very well not be using new features that are unsupported (https://github.com/python/typeshed/issues/10592). If I have...

Alright, so this is going to be a fun project. I may tell you things you already know, but that was new to me and there are a few questions...

Hey @mkmkme, I'll try to get starting on it soon, but I have a few more urgent tasks first, so I'm not totally sure it will happen this week. Regardless,...

Good point, I opened an issue with the maintainers of `types-redis`, we will see if they have ideas.

Please all the PRs you feel are necessary. I barely started working on it and the starting point will be `types-redis`, so the most accurate it is, the better. EDIT:...

ok, so I did something quick and dirty (emphasis on dirty), and copied the content of `types-redis` in to `valkey-py` and renamed Redis -> Valkey / Hiredis -> Libvalkey /...

So just FYI, I'll slowly work on getting mypy to run on the branch in my repo. It's gonna take a while but if someone wants to contribute, please go...

What's your feeling regarding [PEP563](https://peps.python.org/pep-0563/)? I find it much more readable and pleasant to use, but it requires python 3.7+.

Good point, the python version won't be an issue. I might wait for a first working package without PEP 563 just so merging from the typeshed is easy-ish.

Alright, todays update: mypy passes on most of the public interface, and the tests for the commands in sync and async: https://github.com/Rafiot/valkey-py/blob/types/.mypy.ini What do you think would be a good...