express-status-monitor icon indicating copy to clipboard operation
express-status-monitor copied to clipboard

Make chartjs and socket.io not to pull from cdn?

Open bwgjoseph opened this issue 4 years ago • 2 comments

Hi,

I'm using this in offline environment and it doesn't work because it seem that the scripts are pulling from cdn

https://github.com/RafalWilinski/express-status-monitor/blob/6fc93dcccfa600e3570ad3290057add832577d5b/src/public/index.html#L5 https://github.com/RafalWilinski/express-status-monitor/blob/6fc93dcccfa600e3570ad3290057add832577d5b/src/public/index.html#L6

I manually download the files are cdn, place it in my /public to host it instead then point to my host and it does work.. Any idea if the js files can be placed within the /javavscripts directory? So that it can reference local js file rather than cdn?

I am also facing issue where it complains about event-loop-stats not found, ignoring event loop metrics... I'm using node v12

bwgjoseph avatar May 20 '20 17:05 bwgjoseph

Would also be interested in this.

flogy avatar Oct 29 '20 13:10 flogy

I am also facing issue where it complains about event-loop-stats not found, ignoring event loop metrics... I'm using node v12

@bwgjoseph, You are missing the optional event-loop-stats module. It should come installed when you do npm install express-status-monitor.

https://github.com/RafalWilinski/express-status-monitor/blob/8ff29e7c4a98e2adffa27689b3b80b2f33ea8b0f/package.json#L73-L75

It complaints via a warn (not an error) as it is optional. You can do npm install event-loop-stats to get rid of it.


It's optional because the code handles it. https://github.com/RafalWilinski/express-status-monitor/blob/8ff29e7c4a98e2adffa27689b3b80b2f33ea8b0f/src/helpers/gather-os-metrics.js#L9-L13 https://github.com/RafalWilinski/express-status-monitor/blob/8ff29e7c4a98e2adffa27689b3b80b2f33ea8b0f/src/helpers/gather-os-metrics.js#L40-L42

lamweili avatar Jun 05 '22 10:06 lamweili