ScrollCalendar
ScrollCalendar copied to clipboard
RafalManka
feature request: past weeks removal from current month (as it exists in airbnb)
Hey,
First of all, your project is awesome!
now for the feature request: I will use the date 29-Apr-18 to explain: if the Airbnb date picker opens on the 29-Apr-18, it will present the current week and the week before it (grayed out), and not the whole month. it presents:
S M T W T F S April 22 23 24 25 26 27 28 (all grayed out) 29 30
your project presents the whole month and does not allow removing non relevant weeks / days in the current month (without re-compiling).
I think that a simple removal of the irrelevant days in private CalendarMonth(int year, int month, @NonNull CalendarDay[] days) can work as a quick fix.
The motivation for this feature is small smartphone screens that does not have the room for the whole month. This way, the date picker presents the current day for the user without the need to scroll to get to it.
TNX!
I agree this might be a valid feature. Did you already come u with a solution? Would you like to submit a pull request?
On Mon, Apr 30, 2018 at 12:14 AM osoffer [email protected] wrote:
Hey,
First of all, your project is awesome!
now for the feature request: I will use the date 29-Apr-18 to explain: if the Airbnb date picker opens on the 29-Apr-18, it will present the current week and the week before it (grayed out), and not the whole month. it presents:
S M T W T F S 22 23 24 25 26 27 28 (all grayed out) 29 30
your project presents the whole month and does not allow removing non relevant weeks / days in the current month (without re-compiling).
I think that a simple removal of the irrelevant days in private CalendarMonth(int year, int month, @nonnull https://github.com/nonnull CalendarDay[] days) can work as a quick fix.
The motivation for this feature is small smartphone screens that does not have the room for the whole month. This way, the date picker presents the current day for the user without the need to scroll to get to it.
TNX!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RafalManka/ScrollCalendar/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaznuQfHlHWl3ADv78H9J124anRWTddks5ttdjWgaJpZM4Tr1iy .
-- Pozdrawiam, Rafał Mańka +48 609 020 123
I’m on holidays right now, but I will have more time to do this once I’m back.
On Mon, Apr 30, 2018 at 5:38 PM osoffer [email protected] wrote:
didn't find a solution, don't know when I'll have the time for that...
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/RafalManka/ScrollCalendar/issues/10#issuecomment-385340271, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaznrl_Iko8J6mJtHZ6seI_i3hMEvnMks5tts1ogaJpZM4Tr1iy .
-- Pozdrawiam, Rafał Mańka +48 609 020 123
any luck?
I have encountered another challenge in this matter: After setting the date, I want to be able to scroll back to the position of the set date by code. It covers a case that a user sets the date, scrolls down, and then exits the calendar. If he comes back to the calendar, I want to be able to take him to the set date and not the current scroll position (as he left the calendar).
This functionality can use the same mechanism as the first enhancement I brought up.
(tried playing with the recyclerview scroll position, haven't got to a good result :/).
TNX
Hello, sorry but at this point of time, I have too much on my plate to implement this for you. I would suggest forking the repository and implement this by yourself. Sorry for keeping you suspended.
