Vulkan icon indicating copy to clipboard operation
Vulkan copied to clipboard

Bot won't play Deezer links gotten from the Share button

Open miniluz opened this issue 10 months ago • 5 comments

Describe your context I'm using the default values, I just downloaded the image and used Docker.

The path to the bug I simply tried to !play (! being my prefix) a Deezer link (ej. https://deezer.page.link/md6VvKoZ6uHeCiicA) and I'm getting a "Nothing Found. This type of input was too strange, try something else".

Screenshots image image

miniluz avatar Apr 03 '24 17:04 miniluz

Reading the code I see that you expect links to be in the format of www.deezer.com. Is there a reason why deezer.page.link ones aren't supported? They're what you get when you click the "share" button.

miniluz avatar Apr 03 '24 17:04 miniluz

Hello! When I wrote that piece of code i didn't knew about those types of link, have you tried to change the source code to allow this type of link to see if the Deezer module can identify those musics?

RafaelSolVargas avatar Apr 04 '24 03:04 RafaelSolVargas

I was gonna look into it, but playing the links with the expected format still results in a quality that's too low for what I'm looking for. Thank you anyways! If I do come back to this, I'll make a PR.

miniluz avatar Apr 04 '24 15:04 miniluz

Oh. Missclick. I'm not sure if you want this closed?

miniluz avatar Apr 04 '24 15:04 miniluz

I'll leave it open to implement this little change when i got the time

RafaelSolVargas avatar Apr 05 '24 13:04 RafaelSolVargas