Rafael Kraut

Hey @eliykat, thanks for reviewing this so quickly! > My main question is about this [not-very-fun warning from MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/openOrClosedShadowRoot): > > > Non-standard: This feature is non-standard and is not...

@eliykat I have no Safari, could you please test if it works for open ShadowRoot there?

Thanks for your review @chadm-sq! I addressed all of your feedback.

Thanks @eliykat! I just did 2 new changes: 1. I unnested an if-statement by using `continue` in [bitwarden/clients@`6f80de7` (#4119)](https://github.com/bitwarden/clients/pull/4119/commits/6f80de7d89ffc4d03359e31f1ed5bd26a005401c) 2. I missed one occurence where I didn't handle attribute values...

I just tweaked the commit messages for documentation purposes a little bit. From my side this is now ready to merge. Edit: Also just triggered a rebase on master.

Thanks for your time, benchmarks and feedback, I appreciate it. I addressed all of your feedback now, some feedback with some questions. I also untangled the conditions for the `urlNotSecure`...

Hey @djsmith85, thanks for reviewing! ❤️ I just updated the `urlNotSecure` (hopefully the way you expected!). It's now the same as on master, but using `queryDocAll` instead of `document.querySelectorAll`. I...

I just addressed the CodeScene analysis violations. Now we don't have violations left, only a warning.

@eliykat GitHub still shows you requested changes. When clicking on the link it shows nothing. Seems to be a bug? Does this matter for your QA team? I could re-request...

Was a pleasure to iterate through this with you guys! Thanks for merging.