cap icon indicating copy to clipboard operation
cap copied to clipboard

On the x64 / chromium branch getting damaged by an NPC creates a lua error

Open wolfestridershooter opened this issue 1 year ago • 7 comments

When an NPC damages the player with this addon installed on the x64 / chromium branch a lua error occurs. Of course I made sure to disable all of my addons except Wiremod and CAP when testing this.

[cap-master] addons/cap-master/lua/entities/shield_core_buble/init.lua:341: attempt to call method 'GetClass' (a nil value)
  1. v - addons/cap-master/lua/entities/shield_core_buble/init.lua:341
   2. unknown - lua/includes/modules/hook.lua:96 (x47)

(Thanks @gabrie155 for letting me know it only occurred on the x64 / chromium branch) @AlexALX if you see this please review #125 because it will fix this issue and improve on the shield core

wolfestridershooter avatar Feb 01 '24 03:02 wolfestridershooter

@wolfestridershooter that issue is because you are on the chromium branch, i had this error myself, switch back to the normal gmod branch to see if that fixes it, if not, reinstall your game to see if that fixes it.

gabrie155 avatar Feb 11 '24 02:02 gabrie155

@gabrie155 Thanks for letting me know, hopefully your pull request gets merged soon

wolfestridershooter avatar Feb 12 '24 21:02 wolfestridershooter

@wolfestridershooter i'm right now way busy because of life problems and not only so totally unavailable in near future to review anything.

AlexALX avatar Feb 15 '24 18:02 AlexALX

Understood, I hope things get better for you soon. Thank you for responding.

wolfestridershooter avatar Feb 17 '24 20:02 wolfestridershooter

@AlexALX ahh hope everything works out well for you!

@wolfestridershooter yeah i think its because that ENT:GetClass doesnt exist on chromium, since its trying to find it, it cant, i will try to find something similier that will fix it entirely on chromium.

gabrie155 avatar Feb 21 '24 07:02 gabrie155

@wolfestridershooter error is fully fixed!, it will work for both the normal branch and chromium branch

gabrie155 avatar Feb 21 '24 07:02 gabrie155

@wolfestridershooter https://github.com/gabrie155/cap-shield-core-fixed/commit/f550c3501e6c3ba341658a1698ddada4999e28ec

gabrie155 avatar Feb 21 '24 07:02 gabrie155