pyuvsim icon indicating copy to clipboard operation
pyuvsim copied to clipboard

Write a memo about analytic tests (point sources, point at paper for diffuse)

Open bhazelton opened this issue 4 years ago • 4 comments

To explain why it can be used as a simulator of record.

Could be a memo or notebook. At the very least, we should definitely point out the unit tests that test against analytic simulations.

bhazelton avatar Jul 10 '20 20:07 bhazelton

The memo should document the math, but obviously the code documentation is the repo.

We'd certainly like a standard template to compare visibility simulators against at the sort of zero-level analytic calculation level.

jaguirre avatar Jul 10 '20 21:07 jaguirre

Will this involve the paper that @aelanman and I are writing?

On Fri, Jul 10, 2020 at 2:35 PM James Aguirre [email protected] wrote:

The memo should document the math, but obviously the code documentation is the repo.

We'd certainly like a standard template to compare visibility simulators against at the sort of zero-level analytic calculation level.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RadioAstronomySoftwareGroup/pyuvsim/issues/312#issuecomment-656901952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWRXQW4CRZC3FFHIFNHOTR26CRJANCNFSM4OW5SSLA .

steven-murray avatar Jul 10 '20 21:07 steven-murray

Yes, but here we're talking about a clear statement in the README and on ReadTheDocs that we're testing against analytic calculations to provide a basis for validating other simulators.

dannyjacobs avatar Aug 03 '20 17:08 dannyjacobs

@aelanman maybe this is something you can spend a little time on this week? In particular, we want a memo(-ish document) using words and a bit of math to describe the analytic calculations that form the basis of our tests. That's not just the diffuse reference calculations but also the basic point source stuff.

jpober avatar Aug 03 '20 17:08 jpober