pyuvdata icon indicating copy to clipboard operation
pyuvdata copied to clipboard

Make UVFlag add smarter

Open adampbeardsley opened this issue 6 years ago • 2 comments
trafficstars

Right now the UVFlag add method requires an axis to be specified and it blindly concatenates. We should make it smarter to check for compatibility and figure out which axis to add along, like UVData. Similar to UVData, we should also add a fast_concat method.

adampbeardsley avatar Aug 13 '19 20:08 adampbeardsley

The current implementation of add basically is fast_concat luckily. Just need to build up checks for a more safe add.

mkolopanis avatar Aug 27 '19 17:08 mkolopanis

Generally need to add more checking as is done with the other objects. In particular, make sure the right thing happens in the case of overlapping and differently sorted data.

see https://github.com/RadioAstronomySoftwareGroup/pyuvdata/issues/1102 and https://github.com/RadioAstronomySoftwareGroup/pyuvdata/pull/1105 for reference

bhazelton avatar Mar 16 '23 17:03 bhazelton