Dcp utils miriad baseline fix

[telegraphic]

trafficstars

Minor bugfix for MIRIAD baseline calculations.

Description

MIRIAD indexes antennas starting at 1, not 0, so comparator should be >255 instead of >=255. Changed a comparator from >= 255 to >255.

Motivation and Context

Minor bugfix for code to calculate baseline ID in MIRIAD convention. The code was correct for 0-indexed antennas (ANT0, ANT1, ...), but MIRIAD uses 1-indexed antennas (ANT1, ANT2 ...).

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Documentation change (documentation changes only)
• [ ] Version change
• [ ] Build or continuous integration change

Checklist:

• [x] I have read the contribution guide.
• [x] My code follows the code style of this project.

Bug fix checklist:

• [x] My fix includes a new test that breaks as a result of the bug (if possible).
• [ ] All new and existing tests pass.
• [ ] I have updated the CHANGELOG.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.92%. Comparing base (4fba712) to head (ae02e23). Report is 305 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20869    20869           
=======================================
  Hits        20853    20853           
  Misses         16       16           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.