pyuvdata icon indicating copy to clipboard operation
pyuvdata copied to clipboard

Spline Bug in Interpolation Function

Open nfcarl opened this issue 2 years ago • 4 comments

It appears that .interp() function will not adjust to changes made in spline_opts if resuse_spline=True. In order for spline_opts to work, it needs reuse_spline=False, which is not ideal. This should be fixed so that the parameter will reuse the spline unless there are changes made to the spline options.

Thank you!

nfcarl avatar May 24 '23 19:05 nfcarl

@nfcarl Which version of pyuvdata are you seeing this?

piyanatk avatar May 25 '23 08:05 piyanatk

The most recent version.

nfcarl avatar May 25 '23 20:05 nfcarl

To clarify, the main issue is that it should detect a change in spline_opts and perhaps provide an error message, rather than just running the program. If we have reuse_spline=True, then we probably want it to tell you if you are trying to change the spline_opts it won't use the new options.

nfcarl avatar Jun 08 '23 17:06 nfcarl

This isn't intrinsically a bug, if the reuse_spline keyword is set, it should reuse the old spline. But the docstrings should be clarified to say that spline_opts is ignored if reuse_spline is True.

bhazelton avatar Jul 02 '24 15:07 bhazelton