Chisel.Prototype icon indicating copy to clipboard operation
Chisel.Prototype copied to clipboard

Improve line rendering code

Open LogicalError opened this issue 4 years ago • 2 comments

We have line rendering code that can render lines with a given thickness and optionally with dashes, but it's imperfect and can definitely be done better more efficiently and have better quality visuals

We should rewrite this and use this everywhere and remove all dependencies on unity line rendering code. This could then also be used for runtime editing

LogicalError avatar Sep 23 '20 11:09 LogicalError

You should probably have an IRenderer that has an implementation for unity, using a commandbuffer that constructs line mesh, similar to https://github.com/realgamessoftware/dear-imgui-unity/blob/master/ImGuiNET.Unity/Renderer/ImGuiRendererMesh.cs

babooncodes avatar Oct 17 '20 08:10 babooncodes

@baboongd that would make a lot of sense! The current line rendering code was written before all of this was available in Unity, so it couldn't take advantage of it. But now it definitely makes sense to use Compute buffers to create the line geometry

LogicalError avatar Oct 18 '20 06:10 LogicalError