Comment icon indicating copy to clipboard operation
Comment copied to clipboard

Option to allow replies of replies to be serialized.

Open TSolo315 opened this issue 3 years ago • 3 comments

The BaseCommentSerializer's get_replies method only returns replies if the comment has no parent comment. This means replies of replies are always ignored.

https://github.com/Radi85/Comment/blob/1b5a0437a7f2a95a4de4e7de12027f49fe52d92d/comment/api/serializers.py#L70-L82

TSolo315 avatar Mar 25 '21 20:03 TSolo315

This means replies of replies are always ignored

As of now, I don't think we can add a reply to a reply. Comments can only be nested up to a single level. Any changes to the hierarchy would require changes to the Comment model and potentially, quite a few more things.

The option seems promising but would probably require a lot of structural changes in the application. Maybe you can start a discussion on this topic.

abhiabhi94 avatar Mar 26 '21 05:03 abhiabhi94

@abhiabhi94, I believe the challenge for this feature is the UI implementation only. I don't think that will be any issue with the structure changes since our model structure allows nested replies.

In which release do you guys think we should implement this?

Radi85 avatar May 07 '21 09:05 Radi85

I think this will break a lot of current manager methods, we can probably keep this for the major version bump.

abhiabhi94 avatar May 11 '21 15:05 abhiabhi94