rocm-cmake icon indicating copy to clipboard operation
rocm-cmake copied to clipboard

Published 20 hours ago • verified publisher icon RadeonOpenCompute

find_package (ROCM is confusing

Open saadrahim opened this issue 4 years ago • 1 comments

Invoking find_package( ROCM 0.5 CONFIG QUIET PATHS ${ROCM_PATH} /opt/rocm ) to include rocm-cmake is confusing.

We should consider changing the name to ROCM-CMAKE.

saadrahim avatar Jun 17 '21 15:06 saadrahim

@pfultz2 Can you weigh in on this? Using the name ROCM is confusing, especially with the version numbers which don't match the ROCm version number, and we have the opportunity to make a breaking change with ROCm 5.0.

lawruble13 avatar Sep 29 '21 19:09 lawruble13

Hi @saadrahim, is there any further work required for this ticket? Can I close it? Thanks.

nartmada avatar Apr 30 '24 01:04 nartmada

It is find_package(ROCmCMakeBuildTools) in ROCm 6.1 and later, although find_package(ROCM) remains available for backwards-compatibility.

cgmb avatar Apr 30 '24 15:04 cgmb