llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

ROCM 5.6 release: Incorrect version in hipvars.pm

Open littlewu2508 opened this issue 2 years ago • 1 comments

In ROCM 5.6 release, hipvars.pm is still using $HIP_BASE_VERSION_MINOR = "5"; and $HIP_BASE_VERSION_PATCH = "0";

littlewu2508 avatar Jul 03 '23 02:07 littlewu2508

@david-salinas is looking into this, specifically if these macros can be removed so we don't need to worry about them falling out of sync again in the future.

lamb-j avatar May 14 '24 13:05 lamb-j

A couple of comments to consider for this issue:

  1. we are deprecating the use of Perl in HIPCC, and these Perl files will be removed in an upcoming Release.
  2. There is a C++ version of "hipcc" and "hipconfig" that have a similar issue.
  3. The HIP version information is actually kept in a config file ($HIP_PATH/share/hip/version), that the hipcc/hipconfig tools read. The use of local variables for HIP version are just place holders in case the version file cannot be read.
  4. We are likely not going to make any changes to hipcc in already released Releases, that don't provide technical/funcitonal benefit

We can clean up the C++ hipcc/hipconfig tools so that we no longer have to manually update local variable place holder version numbers.

david-salinas avatar Jan 07 '25 20:01 david-salinas

This fix will be included in ROCm 6.4. Closing as resolved, please feel free to open another issue if there are further problems upon release. Thank you!

lucbruni-amd avatar Jan 30 '25 16:01 lucbruni-amd