llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

[Feature]: hipcc should try to detect --offload-arch on Windows

Open ScottTodd opened this issue 3 months ago • 1 comments

Suggestion Description

This code uses rocm_agent_enumerator on Linux: https://github.com/ROCm/llvm-project/blob/4e3aee93a8f8ce1cf184befad10f2a814798f563/amd/hipcc/src/hipBin_amd.h#L778-L796

Windows currently has hipInfo.exe (which is similar to rocminfo). Windows and Linux have amdgpu-arch. It seems like hipcc could try using amdgpu-arch? I'm also wondering if we would want to provide rocm_agent_enumerator on Windows too, and why we have both that and amdgpu-arch.

Context: https://github.com/ROCm/TheRock/pull/1571. We had a test running on Linux and Windows that omitted --offload-arch. This was passing on Linux but silently failing on Windows, until https://github.com/ROCm/rocm-systems/commit/e79eaaa8a54cfe94e9b0d04f5bf7137f53d36b2d turned the silent failure into a crash. That PR changes the test to explicitly pass --offload-arch on both platforms using amdgpu-arch to look up the gfx target.

Operating System

Windows

GPU

N/A

ROCm Component

hipcc

ScottTodd avatar Sep 23 '25 23:09 ScottTodd