ROCT-Thunk-Interface
ROCT-Thunk-Interface copied to clipboard
Repository branch layout is confusing and not inclusively named
Regarding the layout of this repository:
- The
rocm-5.4.3tag is ahead ofmasterand thedevbranch has been unused since 2016. - The branch overview also doesn't make it obvious that the latest
rocm-5.4.3is actually a few commits ahead ofmaster. - The primary development branch being named
masterinstead ofmainortrunkgoes against inclusiveness best practices.
Potential fixes:
- Rename
mastertomain. - Remove unused non-release branches like
devto avoid confusion. - Put all new commits on main and branch releases off of main. I think this is already the case at the moment. However, to make sure that main is always the "latest" code, commit all changes to
mainand then explicitly backport/cherrypick those commits into the release branches if post-release bugfixes are needed. I.e. don't allow manual commits onto release branches after they have been cut. This approach is used e.g. by the llvm-project repository.
Thanks for the comment. This is something that I am working on with the Infrastructure team. Previously I was manually updating the project myself, but it's a simple process so it's been automated. However the master branch was missed for this and other projects, so I am working with our internal Infra team to ensure that master is always aligned with the latest release.
Just updating here, we're merging thunk into ROCr soon, so the release and branching will be more sane. Including updating a dev-type branch more than once a decade