ROCR-Runtime icon indicating copy to clipboard operation
ROCR-Runtime copied to clipboard

Any 4.0.x version?

Open gmarkomanolis opened this issue 4 years ago • 5 comments

Hi,

I assume this is typical as it seems the 3.10.x works but as we install everything from scratch, could you make available a 4.0.x branch to comply with the rest ROCm repos?

thank you, George

gmarkomanolis avatar Jan 07 '21 14:01 gmarkomanolis

any updates on this for 4.0.x ?

powderluv avatar Feb 19 '21 19:02 powderluv

There may not be a 4.0.x branch, but there is at least a rocm-4.0.0 tag, if that helps. It points to the commit where 3.10 was merged into master. So, for the time being, 4.0.0 is exactly equivalent to the tip of 3.10.

yalue avatar Feb 19 '21 19:02 yalue

4.0.1 was a point release to fix specific bugs only. ROCr had no updates relevant to these bugs so remains at 4.0.0 (which as pointed out above is also identical to 3.10).

skeelyamd avatar Feb 22 '21 22:02 skeelyamd

One generic comment, it would be great for all the related to ROCm parts to have same approach about versioning and always name one even if it is the same with older one. This way some scripts can find always a repository branch or tag if we ask for the 4.0.0 for example. In some ROCm repos, there is an updated branch version for example, in some other only tags. When I select the tag rocm-4.0.0 shoes last commit of 3.10.0 and no other explanation that nothing was updated, so this is not a mistake. Just maybe try to commit even a text change or something at least to feel like pointing in the correct version. Thanks for your work!

gmarkomanolis avatar Feb 27 '21 19:02 gmarkomanolis

I believe 4.1 is tagged, see https://github.com/RadeonOpenCompute/ROCR-Runtime/tree/rocm-4.1.x

JonChesterfield avatar Mar 25 '21 13:03 JonChesterfield