Radarr icon indicating copy to clipboard operation
Radarr copied to clipboard

Umlauts from German Language get replaced with their non-umlaut counterparts (Ä->A, Ö->O, Ü->U) instead of following language standard.

Open Lokilicious opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing open and closed issues

Current Behavior

When triggering a search for a German movie with Umlauts (Ä,Ö,Ü) i can observe that it replaces the Umlauts with their regular counterparts.

Example:

Actual Name: Drachenzähmen leicht gemacht (taken from tmdb) https://www.themoviedb.org/movie/10191-how-to-train-your-dragon/translations#de-DE In the request it looks for : Drachenzahmen leicht gemacht

2023-10-13 07:11:27.4|Trace|HttpClient|Res: HTTP/1.1 [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=Drachenzahmen%20leicht%20gemacht%203%20Die%20geheime%20Welt%202019: 200.OK (669 bytes) (149 ms)

This leads to no results being found on the indexer.

Expected Behavior

Umlauts should be replaced like common in German language:

Ä->AE, Ö->OE, Ü-> UE

So the request should look like this: Drachenzaehmen leicht gemacht

2023-10-13 07:11:27.4|Trace|HttpClient|Res: HTTP/1.1 [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=Drachenzaehmen%20leicht%20gemacht%203%20Die%20geheime%20Welt%202019: 200.OK (669 bytes) (149 ms)

Steps To Reproduce

  1. Create a Custom Format which wants German language
  2. Add a movie like "How to tame your dragon" which has Umlauts in the german title
  3. Trigger a search and observe the trace logs

Environment

- OS:
- Radarr: 5.0.3.8127
- Docker Install: Yes
- Using Reverse Proxy: No
- Browser: All
- Database: Sqlite 3.41.2

What branch are you running?

Master

Trace Logs? Not Optional

2023-10-13 07:11:25.3|Info|ReleaseSearchService|Searching indexers for [How to Train Your Dragon: The Hidden World]. 1 active indexers
2023-10-13 07:11:25.3|Debug|Torznab|Downloading Feed https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=How%20to%20Train%20Your%20Dragon%20The%20Hidden%20World%202019
2023-10-13 07:11:25.3|Trace|HttpClient|Req: [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=How%20to%20Train%20Your%20Dragon%20The%20Hidden%20World%202019
2023-10-13 07:11:25.3|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False'
2023-10-13 07:11:25.8|Trace|HttpClient|Res: HTTP/1.1 [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=How%20to%20Train%20Your%20Dragon%20The%20Hidden%20World%202019: 200.OK (669 bytes) (537 ms)
2023-10-13 07:11:25.8|Debug|Torznab|Downloading Feed https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=Drachenzahmen%20leicht%20gemacht%203%20Die%20geheime%20Welt%202019
2023-10-13 07:11:25.8|Trace|RateLimitService|Rate Limit triggered, delaying 'tntracker.org' for 1.460 sec
2023-10-13 07:11:27.3|Trace|HttpClient|Req: [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=Drachenzahmen%20leicht%20gemacht%203%20Die%20geheime%20Welt%202019
2023-10-13 07:11:27.3|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False'
2023-10-13 07:11:27.4|Trace|HttpClient|Res: HTTP/1.1 [GET] https://tntracker.org/api/torznab/api?t=search&cat=2000,2040&extended=1&apikey=(removed)&offset=0&limit=100&q=Drachenzahmen%20leicht%20gemacht%203%20Die%20geheime%20Welt%202019: 200.OK (669 bytes) (149 ms)
2023-10-13 07:11:27.4|Debug|ReleaseSearchService|Total of 0 reports were found for [How to Train Your Dragon: The Hidden World] from 1 indexers
2023-10-13 07:11:27.4|Info|DownloadDecisionMaker|No results found
2023-10-13 07:11:27.4|Trace|Http|Res: 5801 [GET] /api/v3/release?movieId=705: 200.OK (2170 ms)
2023-10-13 07:11:27.4|Debug|Api|[GET] /api/v3/release?movieId=705: 200.OK (2170 ms)

Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.

  • [X] I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.

Lokilicious avatar Oct 13 '23 05:10 Lokilicious

Ive noticed that there was the same issue some years ago: https://github.com/Radarr/Radarr/issues/932

Back then it appeared to be fixed, but i still have the problem, maybe some regression?

Lokilicious avatar Oct 13 '23 06:10 Lokilicious

After digging into the code myself i found that in file Radarr/src/NzbDrone.Core/Parser/Parser.cs some mapping to the correct representation for german umlauts its happening.

As far as i see this is only implemented for newznab and not for torznab as it looks like.

Lokilicious avatar Oct 27 '23 09:10 Lokilicious

Seems related to https://github.com/Radarr/Radarr/pull/8173 perhaps there is a more generic diacritic conversion fix needed?

Jason-Coyne avatar Apr 03 '24 20:04 Jason-Coyne