Subtitle files incorrectly renamed

[kdbruin]

Describe the bug When importing external subtitle files (SRT) they get named incorrectly. Instead of including a language code they are numbered sequentially.

To Reproduce Steps to reproduce the behavior:

1. Add a new movie and go to movie page
2. Copy files to the new directory, including movie.mp4, 6_English.srt, 16_Dutch.srt
3. Update movie info and scan files
4. Preview rename for movie and apply

Expected behavior The subtitle files should be named movie.en.srt and movie.nl.srt instead of movie.1.srt and movie.2.srt.

Desktop

• OS: Linux Ubuntu 19.10
• Mono Version: 5.20.1.34
• Version 0.2.0.1480 radarr.debug.txt

Debug Logs Turn on debug logs under Settings -> General and wait for the bug to occur again. Upload the full log file here (or another site and link it). Issues will be closed, if they do not include this!

AB#837

[D3nn3]

Subtitles in Radarr are a mess to be honest, sorry to be so blunt.

I'm not a Radarr dev but I just looked over the code yesterday because I have also problems with subtitles and if I'm not mistaken Radarr checks only for the language iso codes that's why it doesn't recognize the languages.

If some dev is willing to takle all subtitle issues at once (language detection, sub directories, forced subtitles) I'm willing to help. Since I'm not primarily a C# dev and don't know the Radarr code base at all I don't think I'd be able to do it myself/alone.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Please verify that this is still an issue with the latest version of Radarr and report back. Otherwise this issue will be closed.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Please verify that this is still an issue with the latest version of Radarr and report back. Otherwise this issue will be closed.

[Qstick]

@D3nn3 Still around?

[D3nn3]

Of course @Qstick :) What do you need?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Please verify that this is still an issue with the latest version of Radarr and report back. Otherwise this issue will be closed.

[hashworks]

This is still an issue.

[wsegatto]

Same as #5268 and still bugging me. :(

[bakerboy448]

this still an issue on the newer versions of v3?

[arabcoders]

@bakerboy448 Indeed it still happens not sure about other language but it does for Arabic subtitles files.

When renaming using Radarr GUI movie.year.ar.srt become movie.year.srt

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Please verify that this is still an issue with the latest version of Radarr and report back. Otherwise this issue will be closed.

[tehniemer]

This is still an issue. Additionally, it's not preserving forced subtitles and changing three letter code languages to two letter code. Example below.

move Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ Bluray-1080p\ \(tt1190080\).mkv -> Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ \[imdb-tt1190080\]\[Repack+Proper\]\[Bluray-1080p\ Proper\]\[8bit\]\[x264\]\[DTS\ 5.1\]-METIS.mkv
move Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ Bluray-1080p\ \(tt1190080\).eng.forced.srt -> Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ \[imdb-tt1190080\]\[Repack+Proper\]\[Bluray-1080p\ Proper\]\[8bit\]\[x264\]\[DTS\ 5.1\]-METIS.1.en.srt
move Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ Bluray-1080p\ \(tt1190080\).eng.srt -> Multimedia/Movies/2012\ \(2009\)/2012\ \(2009\)\ \[imdb-tt1190080\]\[Repack+Proper\]\[Bluray-1080p\ Proper\]\[8bit\]\[x264\]\[DTS\ 5.1\]-METIS.2.en.srt

[mvanbaak]

On rename, some subtitles are not renamed correctly.

I had .pt-BR.srt subtitle, and it lost the pt-BR part on rename. See screenshots.

Radarr version 4.0.0.5745

Right before rename: https://ptpimg.me/5aq73z.png Right after rename: https://ptpimg.me/d051gh.png

[d3kstr0za]

I've also had issues with .hr.srt, .bs.srt, and .sr.srt getting replaced with numbers (e.g .1.srt) after I've changed my Movie Name pattern and ran a massive rename.

[tehniemer]

This PR in Sonarr may be worth looking into as a fix for this issue. I'm not good with code so I won't be much help past here. https://github.com/Sonarr/Sonarr/pull/4924