postcss-prefix-selector icon indicating copy to clipboard operation
postcss-prefix-selector copied to clipboard

Update plugin to PostCSS 8 and visitors API

Open RadValentin opened this issue 3 years ago • 5 comments

This PR continues the work done in #93 to make the plugin completely support PostCSS 8 as part of v2.0.0

TODO

  • [ ] Find a way to check if file is ignored once per file not once per rule
  • [ ] Follow PostCSS plugin guidelines closely
  • [ ] Cover all possible atrules in tests
  • [ ] Set "postcss": "^8.0.0" as peer and dev dependency
  • [ ] Measure performance
  • [ ] Consider options argument for transform function

Links

  • https://evilmartians.com/chronicles/postcss-8-plugin-migration

RadValentin avatar Aug 19 '21 14:08 RadValentin

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :( for instance, https://github.com/vbenjs/vite-plugin-svg-icons/issues/47

eshimischi avatar Mar 14 '22 19:03 eshimischi

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :( for instance, vbenjs/vite-plugin-svg-icons#47

This PR won't fix the problem in the issue you linked, that's being caused by my plugin requiring a newer version of PostCSS (7 or 8). I can try to see if it will run on PostCSS 5 and publish an update to make the dependency less restrictive. Will take a look at it this weekend.

RadValentin avatar Mar 15 '22 12:03 RadValentin

Any progress here, some 3rd-party libraries have issues with this library not postcss 8.0 :( for instance, vbenjs/vite-plugin-svg-icons#47

I published a new version of the prefixer, it should fix the issues you were mentioning

RadValentin avatar Mar 16 '22 13:03 RadValentin

any updates about this issue?

windy avatar May 30 '22 15:05 windy

@windy I don't have time right now for this project. My estimate is that it will be done sometime in July.

RadValentin avatar May 31 '22 21:05 RadValentin