Rabby icon indicating copy to clipboard operation
Rabby copied to clipboard

Add Support for Multiple QR-based hardware wallets

Open shekohex opened this issue 2 years ago • 12 comments

Currently, I can't add two or more QR-based hardware wallets to Rabby. And even I can't add more than one of two different wallets like (Airgap and Keystone).

Related issues: #1314 and #557

Use case: Currently, I have a few old phones and on each one of them I do have airgap vault installed, and basically I want to use them as a multisig wallet with Safe (https://safe.global).

~P.S I believe Metamask supports adding more than one Keystone/QR Based wallets.~

Edit: Metamask does not support this either.

shekohex avatar Dec 21 '23 17:12 shekohex

MetaMask is not support adding more than one QR Based wallets either, we have discussed with Keystone team about this but unfortunately can't resolve this problem currently

vvvvvv1vvvvvv avatar Dec 22 '23 03:12 vvvvvv1vvvvvv

MetaMask is not support adding more than one QR Based wallets either, we have discussed with Keystone team about this but unfortunately can't resolve this problem currently

Yeah, I did try Metamask too, and it looks like it is an issue with the protocol? Will check Keystone/Airgap for that.

shekohex avatar Dec 22 '23 11:12 shekohex

For Airgap, why not use their official Protocol instead of using Keystone's one? In Airgap wallet, I can add many Airgap vaults to one wallet, and it works this way without any issues.

shekohex avatar Dec 22 '23 11:12 shekohex

I spent some time looking into the wallet and keyring service code and I cannot see any hard stoppers that would prevent you from having multiple QR keyrings apart from some of the wallet code being written to only support one keyring of a certain type.

@vvvvvv1vvvvvv could you give us a hint on where the issue lies and how keystone is involved?

also a bit off topic: is there a dev chat or something where one can ask questions about or discuss the code? There are some parts of the code that I do not understand or why they are necessary.

suicide avatar Feb 05 '24 05:02 suicide

Does this apply to using Keystone with USB?

Can you add 2x Keystone with USB? (I'm trying to but getting the warning below)

It's not supported to import multiple Keystone devices If you switch to a new Keystone device, the current device's address list will be removed before starting the import process.

MAHDTech avatar Mar 11 '24 10:03 MAHDTech