Raas Ahsan

Results 35 comments of Raas Ahsan

Another one, which I suspect is the same source of nondeterminism: ``` ==> X org.http4s.client.blaze.Http1ClientStageSuite.Utilize a provided Host header 0.012s munit.FailException: /home/runner/work/http4s/http4s/blaze-client/src/test/scala/org/http4s/client/blaze/Http1ClientStageSuite.scala:185 assertion failed 184: val requestLines = request.split("\r\n").toList 185:...

sorry i missed this - seems like the exception is being thrown here https://github.com/http4s/http4s/blob/series/0.21/blaze-client/src/main/scala/org/http4s/client/blaze/ReadBufferStage.scala#L43 understanding how this state machine works will probably be the key to understanding why this bug...

Yeah this is definitely a tricky one. This may just be a fundamental flaw in how http4s models middleware and web sockets. You see similar problems when isolated to middleware...

Sorry, referring to blaze-server's pool. These tests changed: https://github.com/http4s/http4s/pull/4097/files#diff-1c927ff90072dbf8dd378275fdbc4ec883158c37c054c283c0ec6cb4a587a8bcL123

It's worth considering #1459 under those principles as well

> If multiple implementations exist, can we reconcile them before inclusion? If not, maybe the design space is still unsettled. Example: circuit, which also exists in Monix. It's also worth...

Sounds good, I can try to come up with some other names. I also don't think we really need the `MakeQueue` trait. It's a neat trick, but passing in an...

> The larger issue here is that the lifecycles of the server socket and all accepted sockets are now bound to the same stream. Ok so this is actually not...

Sorry for dropping the ball on this (I've been a bit busy), but I think it's ready for a deeper review. It does deserve some tests which I'll try to...

Should failing remove the entry from the map, or should that be pushed back to the user? I could see it trying to acquire the `Resource` again. I think this...