TEASER icon indicating copy to clipboard operation
TEASER copied to clipboard

Issue544 retail profiles

Open DaJansenGit opened this issue 3 years ago • 4 comments

This PR brings some options to make manipulate the existing profiles to create a bit more dynamic. Main functions are:

  • timeset and scaling factor to reduce (or increase) the profiles on weekend for persons, lighting and machines
  • opening-, closing times to cut/extend existing profiles for persons, lighting and machines
  • heating/cooling set back temperatures and time schedules to allow easy night set back

This should also close #544 as air curtain already exists and only retail profiles were missing.

DaJansenGit avatar Oct 27 '21 15:10 DaJansenGit

Let me join the discussion here:

  • I see the point of more code and more effort to maintain
  • I would also see the benefit of having such functionality in TEASER
  • as the default does not change anything we had before, I would vote for an integration within the "TEASER Core"

I would only discuss the naming of the schedule function.

MichaMans avatar Oct 29 '21 09:10 MichaMans

@MichaMans Thank you for revising!

My main goal was to open a discussion and think about a good way for implementation. As my opinion is not strong in this, I agree with @DaJansenGit and @MichaMans to add those changes to the Teaser core.

MartinRaetz avatar Oct 29 '21 12:10 MartinRaetz

Thanks for your review (Martin & Michael!). I will implement the requested minor changes and integrate an example to show the behaviour of the functions. I will re-request your review afterwards Martin. Thanks again!

DaJansenGit avatar Oct 29 '21 13:10 DaJansenGit

Sorry that this took so long, I finally made the requested changes. @MichaMans are you still available for a small review? :) Otherwise, I will ask someone else. Thanks in advance.

DaJansenGit avatar Aug 16 '22 08:08 DaJansenGit

@Dawac Could you have a look on this?

DaJansenGit avatar Sep 14 '22 16:09 DaJansenGit