TEASER
TEASER copied to clipboard
RWTH-EBC
outer walls calculation fails for two_elements export
For a given thermal zone with no outerwalls for example:
- 4 internal walls
- 1 Floor
- 1 Rooftop
The roof will be recognized as outerwall in two_element.py line 852:
But in the simulation this thermal zone will have problems because r_Rest_ow <= 0 in two_element.py line 878:
This happens because conduction for a thermal zone with this conditions is 0, because of this if-statement in two_element.py line 873:
Solution:
Looks indeed as a bug IMHO. Maybe can one of the hands (@PRemmen or @MichaMans) give some feedback if this is puprose and we overlook something?
@DaJansenGit @D-Cordoba looks like a good catch. Probably this is also a bug on the other modules. 👍
In general as already said in #690 you really need to be careful with TEASER and ROM when defining "unusual" buildings (like one without any outerwalls).
@PRemmen Thank you for the quick response :)
In general this shouldn't occur because we will integrate a method to lump zones without any exterior elements to adjacent zones which have exterior elements. Anyway we will investigate the influence of zones without any exterior elements.
@D-Cordoba Could you please open a merge request with a fix? Please have also a look on the other modules (1-4 elements)
Just to keep things together, I want to add that https://github.com/RWTH-EBC/TEASER/issues/637 is related to that topic.
