TEASER icon indicating copy to clipboard operation
TEASER copied to clipboard

Use common base class for all Archetypes

Open marcusfuchs opened this issue 4 years ago • 2 comments

For #665. From looking at the code, there have been separate base classes for Residential and NonResidential archetypes since 2015, but there was never any need for these to differ. Therefore, I suggest to simplify things into one common Archetype base class. I think that this makes for a clearer starting point to create new archetypes and an easier foundation to understand the currently available ones.

As there were no differences between the two previous base classes, this does not lead to any functional changes.

marcusfuchs avatar Dec 03 '20 19:12 marcusfuchs

Coverage Status

Coverage increased (+0.006%) to 88.997% when pulling ff213d5293f204d1c5a2995a03bc3481d453bcab on marcusfuchs:issue665_baseclass into c2ded844a7f5c73c53c7ecc9238c27bc205ece41 on RWTH-EBC:development.

coveralls avatar Dec 03 '20 21:12 coveralls

I'll transfer it to a teaser branch to get CI running and then merge if there are not tests failing

PRemmen avatar Dec 17 '20 11:12 PRemmen