AixLib icon indicating copy to clipboard operation
AixLib copied to clipboard

Published 20 hours ago • verified publisher icon RWTH-EBC

Open Modelica PR

Open FWuellhorst opened this issue 1 year ago • 7 comments

Bundling all changes, we can check CI only once.

FWuellhorst avatar Oct 13 '22 15:10 FWuellhorst

@LauraMaier : We reviewed all changes in the branch anyway. This branch was used to limit the burden on the CI. You can check again if you want to see the OM issues we solved.

FWuellhorst avatar Oct 13 '22 15:10 FWuellhorst

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/openModelicaProject/plots

ebc-aixlib-bot avatar Oct 13 '22 23:10 ebc-aixlib-bot

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/openModelicaProject/plots

ebc-aixlib-bot avatar Oct 14 '22 09:10 ebc-aixlib-bot

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/openModelicaProject/plots

ebc-aixlib-bot avatar Oct 24 '22 15:10 ebc-aixlib-bot

@LauraMaier I added all requested changes. The CI now works :)

FWuellhorst avatar Nov 11 '22 15:11 FWuellhorst

@LauraMaier can you review again? :)

FWuellhorst avatar Nov 18 '22 08:11 FWuellhorst

@LauraMaier : I added all changes or commented my concerns. Please re-review :)

FWuellhorst avatar Dec 06 '22 13:12 FWuellhorst

Thanks for the nice work, only minor changes from my side. And please make sure the changes in the bin directory are intended :)

LauraMaier avatar Jan 30 '23 13:01 LauraMaier

@LauraMaier : I resolved all open issues. Please check again :)

FWuellhorst avatar Feb 08 '23 14:02 FWuellhorst