AixLib icon indicating copy to clipboard operation
AixLib copied to clipboard

Published 20 hours ago • verified publisher icon RWTH-EBC

Issue1171 storage spring cleaning

Open LauraMaier opened this issue 3 years ago • 9 comments

This closes issue #1171

LauraMaier avatar Jan 28 '22 07:01 LauraMaier

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot avatar Jul 15 '22 04:07 ebc-aixlib-bot

@LauraMaier : Could you update the branch to MSL 4.0? Then I will add my review.

FWuellhorst avatar Oct 12 '22 14:10 FWuellhorst

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot avatar Oct 12 '22 22:10 ebc-aixlib-bot

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot avatar Oct 12 '22 23:10 ebc-aixlib-bot

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot avatar Oct 13 '22 04:10 ebc-aixlib-bot

Errors in regression test. Compare the results on the following page https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot avatar Oct 13 '22 21:10 ebc-aixlib-bot

@LauraMaier : Even though the plots dont show, here is the error:

*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageSolarCollector.mos");'.
*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageBoiler.mos");'.

FWuellhorst avatar Oct 14 '22 06:10 FWuellhorst

@FWuellhorst Can you re-review? :)

LauraMaier avatar Oct 17 '22 21:10 LauraMaier

@FWuellhorst Will you be able to re-review in October? :) That would be great ! :)

LauraMaier avatar Oct 21 '22 16:10 LauraMaier