skiros2 icon indicating copy to clipboard operation
skiros2 copied to clipboard

Skill crashes ungracefully if a required parameter is not set

Open matthias-mayr opened this issue 4 months ago • 0 comments

Here a new skill has parameters "Target" and "Task", but the parent skill does not set them. The expectation is that this is displayed in a nicer way than showing the exception in the UI

[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/visitors.py", line 145, in processNode
[skill_manager_node-4]     state = self.execute(procedure)
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 229, in execute
[skill_manager_node-4]     if not self._ground(skill):
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 181, in _ground
[skill_manager_node-4]     if not self._autoParametrizeBB(skill):
[skill_manager_node-4]   File "/home/matthias/Workspaces/skiros2_ws/build/skiros2_skill/skiros2_skill/core/skill_utils.py", line 143, in _autoParametrizeBB
[skill_manager_node-4]     raise Exception("Missing required parameter(s): {}".format(missing_params))
[skill_manager_node-4] Exception: Missing required parameter(s): ['Target', 'Task']
[skill_manager_node-4] 

matthias-mayr avatar Feb 29 '24 13:02 matthias-mayr