Retrieval-based-Voice-Conversion-WebUI icon indicating copy to clipboard operation
Retrieval-based-Voice-Conversion-WebUI copied to clipboard

fix: resolve inconsistent sample rates and improve Train tab layout

Open Wernervanrun opened this issue 1 year ago • 0 comments

Pull request checklist

  • [x] The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)
  • [x] Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.
  • [x] Ensure you can run the codes you submitted successfully. These submissions will be prioritized for review:
    • Introduce improvements in program execution speed;
    • Introduce improvements in synthesis quality;
    • Fix existing bugs reported by user feedback (or you met);
    • Introduce more convenient user operations.

PR type

  • Bug fix / synthesis quality improvement

Description

This commit addresses two issues on the Train tab:

  1. Inconsistent Target Sample Rates:

    • Resolved an issue where switching versions led to inconsistent Target sample rate options. Additionally, I want to point out a missing v2 - 40k configuration file. Despite v2 having a 40k pretrained model:
      • assets/pretrained (32k, 40k, 48k)
      • assets/pretrained_v2 (32k, 40k, 48k)
      • configs/v1 (32k, 40k, 48k)
      • configs/v2 (32k, 48k)
    • Tests showed that the default settings 40k - v2 generated an incorrect 40k - v1 config file. The default settings have been updated to use 48k - v2 to align the sample rates correctly.

    Now:

    • v1 will consistently show 32k, 40k, and 48k
    • v2 will consistently show 32k and 48k

    Note: Ensures that selecting the 40k option for v2 no longer results in an incorrect configuration file.

  2. Repositioned 'Version' Field:

    • Moved the 'Version' field to appear before the 'Target sample rate' field on the Train tab. This improves the logical flow and user experience by ensuring that the 'Version' selection is made before choosing the 'Target sample rate' it is updating.

    Changes:

    • Updated layout on the Train tab to reposition the 'Version' field.

    Note: No functional changes to the data processing were made.

Wernervanrun avatar Aug 07 '24 09:08 Wernervanrun