Retrieval-based-Voice-Conversion-WebUI icon indicating copy to clipboard operation
Retrieval-based-Voice-Conversion-WebUI copied to clipboard

feat+fix: adds compatibility to run.sh for pyenv and let pyenv install python 3.8 if it's not installed

Open pato-pan opened this issue 7 months ago • 2 comments

Pull request checklist

  • [x] The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)

  • [x] Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.

  • [x] Ensure you can run the codes you submitted succesfully. These submissions will be prioritized for review:

    Introduce improvements in program execution speed;

    Introduce improvements in synthesis quality;

    Fix existing bugs reported by user feedback (or you met);

    Introduce more convenient user operations.

PR type

  • Bug fix / new feature

Description

updates run.sh to add pyenv compatibility. Pyenv check was not working as intended, it should be inverted match (with -v). if pyenv exists in the system, it will now install python3.8 and set it as the default for the current folder

This should give support to Arch Linux users, among other distros who suggest users to use pyenv.

Review needed, 2 questions:

  1. Is it safe to set python3.8 as the default for the current folder? If you don't know and no one can verify, let's assume it is. I think it likely is, but I can't account for every possibility.
  2. Which version of python 3.8 do you prefer? If it's not 3.8.19, it should be changed to the one you wish to have installed (like 3.8.0)

Screenshot

  • Please include a screenshot if applicable

not applicable

pato-pan avatar Jul 18 '24 02:07 pato-pan