RecBole icon indicating copy to clipboard operation
RecBole copied to clipboard

[💡SUG] Replace Numpy operations in the `forward` function of SR-GNN and GC-SAN with PyTorch code

Open bkersbergen opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. The models SR-GNN, GC-SAN contain NumPy operations in their forward function which requires repeated data transfers between CPU and GPU during training and inference. This is very inefficient.

Describe the solution you'd like Replace the Numpy operations with PyTorch code.

Describe alternatives you've considered

Additional context

bkersbergen avatar Oct 23 '23 09:10 bkersbergen

@bkersbergen Thank you for your suggestions! The numpy operations in forward are mainly from function "_get_slice". We will rewrite the function and update the model.

Fotiligner avatar Oct 24 '23 14:10 Fotiligner