libcp2p icon indicating copy to clipboard operation
libcp2p copied to clipboard

Peerstore Updates (WIP)

Open bonedaddy opened this issue 5 years ago • 1 comments

CBOR encoding for the message_hello_t will need to be refactored. Space efficiency wise the CBOR container was structured like [[int64_t (pub key len), int64_t (peer id len), bytes (pub key), bytes (peer id)]]. Unfortunately this makes adding multiaddr information since we need to add a few things:

  • number of multiaddrs
  • for each multiaddr the size of the multiaddr
  • the actual bytes data

with the addition of adding multiaddrs to this CBOR container, we will need to change to a format like so

[[int64_t (pub key len), bytes (pub key), int64_t (peer id len), bytes (peer id), int64_t (num addrs), int64_t (addr size), bytes (addr)]]

By doing this we will be able to determine the number of addrs to prepare for iteration, then advance over the CBOR container.

bonedaddy avatar Nov 12 '20 08:11 bonedaddy

CLA Assistant Lite All Contributors have signed the CLA.

github-actions[bot] avatar Nov 12 '20 08:11 github-actions[bot]