3 x crash fix and 1 x read uninitialized fix

Open dlmiles opened this issue 1 year ago • 1 comments

The findUse() probably wants a better review to confirm the UNDO operation left in place is enough, in particular DBundo.c:812

Jun 04 '24 14:06 dlmiles

I took my own suggestion after review in comment https://github.com/RTimothyEdwards/magic/pull/314#pullrequestreview-2096688410

Also looking at the lef/lefWrite.c there was another nearby site which looks like it could trigger the same problem, so I put in the same if() guard. I can also see the same check exists already around line 1560.

https://github.com/RTimothyEdwards/magic/blob/5c7217a6b2d708bc698babe5da62b70f52fee2ec/lef/lefWrite.c#L1560

There is one more site around line 1720 that is unclear if there is a risk there also.

https://github.com/RTimothyEdwards/magic/blob/5c7217a6b2d708bc698babe5da62b70f52fee2ec/lef/lefWrite.c#L1720

Jun 04 '24 22:06 dlmiles

Pulled and merged.

Oct 01 '24 16:10 RTimothyEdwards