rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[Bug] Useless assignment operation in bsp/cvitek/cv18xx_risc-v/SConstruct

Open unicornx opened this issue 1 year ago • 3 comments

RT-Thread Version

master

Hardware Type/Architectures

bsp/cvitek/cv18xx_risc-v/

Develop Toolchain

GCC

Describe the bug

bsp/cvitek/cv18xx_risc-v/SConstruct 中以下赋值操作看上去是没有用的,反而容易引起混淆

rtconfig.CPU='virt64'
rtconfig.ARCH='risc-v'

bsp/cvitek/cv18xx_risc-v/rtconfig.py 中已经设置了 ARCH 和 CPU 如下:

ARCH        ='risc-v'
VENDOR      ='t-head'
CPU         ='c906'
CROSS_TOOL  ='gcc'

Other additional context

No response

unicornx avatar Aug 26 '24 02:08 unicornx

估计是从virt那边复制过来的

heyuanjie87 avatar Aug 26 '24 07:08 heyuanjie87

估计是从virt那边复制过来的

我猜是,后面我找个时间提个 PR 给它删掉

unicornx avatar Aug 26 '24 08:08 unicornx

支持!把一切不合理的东西给整理清楚掉!

BernardXiong avatar Aug 27 '24 03:08 BernardXiong