rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[kernel][mutex] fix bug of thread exit without releasing mutex & add error check log

Open zmshahaha opened this issue 1 year ago • 4 comments

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [ ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [ ] 代码是高质量的 Code in this PR is of high quality
  • [ ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

zmshahaha avatar Aug 23 '24 03:08 zmshahaha

为什么要加no pi

mysterywolf avatar Aug 23 '24 03:08 mysterywolf

为什么要加no pi

优先级继承方式的mutex实现较重(频繁的任务线程优先级调整),对性能有影响。

zmshahaha avatar Aug 23 '24 03:08 zmshahaha

没看懂这个ci报错

zmshahaha avatar Aug 23 '24 09:08 zmshahaha

还有包括,当试图去持有mutex,但超时任务恢复的时候,需要对mutex的优先级进行调整的。

BernardXiong avatar Aug 24 '24 06:08 BernardXiong

还有包括,当试图去持有mutex,但超时任务恢复的时候,需要对mutex的优先级进行调整的。

这个我测的没有问题,代码上也能看到mutex超时恢复调整优先级的逻辑

zmshahaha avatar Aug 29 '24 11:08 zmshahaha

@polarvid 麻烦再review一下呗

mysterywolf avatar Sep 09 '24 22:09 mysterywolf

感觉是ci有bug

zmshahaha avatar Sep 10 '24 03:09 zmshahaha

感觉是ci有bug

image

ROM 超了

polarvid avatar Sep 10 '24 03:09 polarvid

可以将这个BSP改成-O2编译

mysterywolf avatar Sep 10 '24 23:09 mysterywolf

编译问题修了

zmshahaha avatar Sep 11 '24 09:09 zmshahaha