rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

bsp: cvitek: fix cvitek uart driver can not repeat configure

Open Solonix-Chu opened this issue 1 year ago • 4 comments

After first called from uart open, the dw8250_uart_configure API cannot be called again. Otherwise, this will mess up the device, and uart will not act properly to interrupt again.

Analysis: Configure uart device will close recive interrupte, causing uart device to malfunction.

Solution: After configure uart device, enable the device's recive interrupte.

Reviewed-by: Chen Wang [email protected]

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Fixed https://github.com/RT-Thread/rt-thread/issues/9150

你的解决方案是什么 (what is your solution)

After configure uart device, enable the device's recive interrupte.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/cvitek
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 代码是高质量的 Code in this PR is of high quality
  • [x] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Solonix-Chu avatar Jul 27 '24 09:07 Solonix-Chu

@unicornx

Solonix-Chu avatar Jul 27 '24 09:07 Solonix-Chu

@Z8MAN8 请在 #9150 里 AT 我一下,这样我就可以 assign 那个 issue 给你了。

unicornx avatar Jul 29 '24 05:07 unicornx

这个 PR 先解决 #9150 的问题吧,cfg 传参进行配置这部分缺少的问题后面再单独修改吧。

unicornx avatar Aug 16 '24 08:08 unicornx

这个 PR 先解决 #9150 的问题吧,cfg 传参进行配置这部分缺少的问题后面再单独修改吧。

好的 明白

Solonix-Chu avatar Aug 16 '24 08:08 Solonix-Chu

@unicornx 请确认这个PR是否可以合并?

mysterywolf avatar Aug 28 '24 22:08 mysterywolf

@unicornx 请确认这个PR是否可以合并?

我这里没有问题了,也 approve 了。但我看熊大还没有 approve。

unicornx avatar Aug 29 '24 00:08 unicornx

@BernardXiong hi, 请 review & commnet,谢谢。

unicornx avatar Aug 29 '24 01:08 unicornx