rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[timer] The rt_timer_check and _soft_timer_check functions are merged

Open wdfk-prog opened this issue 1 year ago • 4 comments

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  • https://club.rt-thread.org/ask/question/d5c013f9637a6fda.html

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 代码是高质量的 Code in this PR is of high quality
  • [x] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

wdfk-prog avatar Apr 29 '24 14:04 wdfk-prog

  • 第二次推送解决如下问题

https://github.com/RT-Thread/rt-thread/issues/8883

wdfk-prog avatar Apr 30 '24 14:04 wdfk-prog

自己工程编译正常,测试正常

https://github.com/wdfk-prog/ART-PI

image

image

  • 测试正常

wdfk-prog avatar Apr 30 '24 14:04 wdfk-prog

current_tick = rt_tick_get(); 在软件定时器检测和硬件定时器检测中的调用顺序不同;按我理解没有差别,放入前面运行更为合适

    while (!rt_list_isempty(&timer_list[RT_TIMER_SKIP_LIST_LEVEL - 1]))
    {
        t = rt_list_entry(timer_list[RT_TIMER_SKIP_LIST_LEVEL - 1].next,
                          struct rt_timer, row[RT_TIMER_SKIP_LIST_LEVEL - 1]);

        /* re-get tick */
        current_tick = rt_tick_get();

wdfk-prog avatar Apr 30 '24 14:04 wdfk-prog

  • 在硬件定时器检测中的该段代码,我认为可以放入外部判断既可;但是没有实际环境测试;这个地方需要检测一下是否合理
#ifdef RT_USING_SMP
    /* Running on core 0 only */
    if (rt_hw_cpu_id() != 0)
    {
        rt_spin_unlock_irqrestore(&_htimer_lock, level);
        return;
    }
#endif

wdfk-prog avatar Apr 30 '24 14:04 wdfk-prog