rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[kernel timer]rt_timer_check 和 _soft_timer_check 函数是否可以抽出为同一份?

Open wdfk-prog opened this issue 1 year ago • 3 comments

  • 为什么没有抽出为同一个函数,不同点进行处理既可
  • 是效率问题吗?

https://github.com/RT-Thread/rt-thread/blob/b586889216a4cbe7995498b40ae3a69110b3a2d4/src/timer.c#L774-L843

https://github.com/RT-Thread/rt-thread/blob/b586889216a4cbe7995498b40ae3a69110b3a2d4/src/timer.c#L670-L750

wdfk-prog avatar Apr 29 '24 14:04 wdfk-prog

应该不是效率问题,应该是演进的时候谁也没有注意到,如果代码重复率很高,应该抽出来,后续维护的时候不容易出bug

mysterywolf avatar Apr 29 '24 21:04 mysterywolf

welcome PR.

BernardXiong avatar Apr 30 '24 12:04 BernardXiong

  • https://github.com/RT-Thread/rt-thread/pull/8884
  • 已提交

wdfk-prog avatar Apr 30 '24 14:04 wdfk-prog