rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

Published 20 hours ago • verified publisher icon RT-Thread

[libcpu/arm/cortex-a]修改arm/cortex-a启动方式，解决cortex-a开启SMP工作异常问题

Open messigogogo opened this issue 1 year ago • 3 comments

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

https://github.com/RT-Thread/rt-thread/issues/8469 解决issue

你的解决方案是什么 (what is your solution)

对cortex-a cpu的启动步骤仿照aarch64的风格进行了整理，使逻辑更加清晰，并解决了上述问题。已在qemu-vexpress-a9，raspi4-32，phytium开发板上进行测试，目前可以正常启动

请提供验证的bsp和config (provide the config and bsp)

  • BSP: 360866a0b7bc56143fc1e44d5ee778a f40ff977c306726581486ea388fb356
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [ ] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [ ] 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [ ] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [ ] 代码是高质量的 Code in this PR is of high quality
  • [ ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

messigogogo avatar Jan 31 '24 02:01 messigogogo

Good Job!

BernardXiong avatar Jan 31 '24 23:01 BernardXiong

[cpp_check.py 28 INFO] libcpu/arm/cortex-a/mmu.c:211:30: error: Overflow in pointer arithmetic, NULL pointer is subtracted. [nullPointerArithmetic] rt_mpr_start = (void *)0 - rt_mpr_size;

这里也帮忙做个调整吧，原来的代码有些不太规范

BernardXiong avatar Jan 31 '24 23:01 BernardXiong

[cpp_check.py 28 INFO] libcpu/arm/cortex-a/mmu.c:211:30: error: Overflow in pointer arithmetic, NULL pointer is subtracted. [nullPointerArithmetic] rt_mpr_start = (void *)0 - rt_mpr_size;

这里也帮忙做个调整吧，原来的代码有些不太规范

已修改 rt_mpr_start = (void *)((rt_size_t)0 - rt_mpr_size);

messigogogo avatar Feb 01 '24 02:02 messigogogo

你好 这份代码先挂在这里 等https://github.com/RT-Thread/rt-thread/pull/8537 合并之后再麻烦您重新rebase和测试一下~

mysterywolf avatar Feb 20 '24 03:02 mysterywolf

你好 这份代码先挂在这里 等#8537 合并之后再麻烦您重新rebase和测试一下~

好的，这份代码和刚才合入的有一些冲突，我只是重新修改提交一下

messigogogo avatar Feb 20 '24 03:02 messigogogo

你好 这份代码先挂在这里 等#8537 合并之后再麻烦您重新rebase和测试一下~

你们近期会对#8537 进行合入吗？我看那边改动比较大？

messigogogo avatar Feb 21 '24 11:02 messigogogo

你好 这份代码先挂在这里 等#8537 合并之后再麻烦您重新rebase和测试一下~

你们近期会对#8537 进行合入吗？我看那边改动比较大？

在推进着合并，然后开始准备发版本。

BernardXiong avatar Feb 21 '24 12:02 BernardXiong

https://github.com/RT-Thread/rt-thread/pull/8537 已经合并 麻烦重新rebase到最新基线并测试一下把~

mysterywolf avatar Feb 24 '24 01:02 mysterywolf