rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[DeviceDriver] Add CANFD support and correct typos

Open helloeagleyang opened this issue 3 years ago • 2 comments

  • Added CANFD required fields to can.h
  • Fixed typos in can.h and can.c
  • Corrected all the projects affected by the typo

Signed-off-by: Fan YANG [email protected]

拉取/合并请求描述:(PR description)

[

  • 该PR用于在CAN设备驱动中加入CANFD的支持,包括 FD波特率的配置(传统的波特率配置或者基于 bit timing的配置), CANFD消息的支持(增加消息长度到64字节)。此外该PR也fix了发现的几个拼写错误的问题,并将所有受拼写错误影响的驱动适配层一并作了修改

  • 该PR在HPM6750EVKMINI板上做了测试 ]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。 The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • [x] 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

helloeagleyang avatar May 08 '22 14:05 helloeagleyang

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 08 '22 14:05 CLAassistant

我有个建议。CAN设备驱动中 rt_can_control 执行 RT_DEVICE_CTRL_CONFIG时并没有把config写到设备的config结构体去。 我看到serial驱动中 RT_DEVICE_CTRL_CONFIG 都有把serial的config保存在设备的config结构体中,这个地方是否可以PR改进一下。 还有既然有RT_DEVICE_CTRL_CONFIG配置设备,是否可以搞个获取设备配置的命令,用于用户端获取设备当前配置的详细信息,比如RT_DEVICE_GET_CONFIG

cazure avatar Jun 30 '22 02:06 cazure

你好 可以再提交一个适配的驱动的PR嘛?

mysterywolf avatar Aug 14 '22 02:08 mysterywolf