rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard
verified publisher icon RT-Thread

Feature/bsp stm32f407 spi flash

Open Dailingxiang1 opened this issue 1 month ago • 4 comments

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

为bsp/stm32/stm32f407-micu添加spi flash支持

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [x] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 代码是高质量的 Code in this PR is of high quality
  • [x] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [ ] 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Dailingxiang1 avatar Nov 25 '25 13:11 Dailingxiang1

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page 点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾） Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：feature/bsp_stm32f407_spi_flash
  • 设置PR number为 \ Set the PR number to：10979
  1. 等待工作流完成 | Wait for the workflow to complete 格式化后的代码将自动推送至你的分支。 The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 feature/bsp_stm32f407_spi_flash 分支，关联的 Pull Request 也会同步更新。 Once completed, commits will be pushed to the feature/bsp_stm32f407_spi_flash branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐 If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions[bot] avatar Nov 25 '25 13:11 github-actions[bot]

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-micu/.config
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/.mxproject
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/CubeMX_Config.ioc
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/main.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/main.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
  • bsp/stm32/stm32f407-micu/board/Kconfig
  • bsp/stm32/stm32f407-micu/board/ports/SConscript
  • bsp/stm32/stm32f407-micu/board/ports/spi_flash_init.c
  • bsp/stm32/stm32f407-micu/project.uvoptx
  • bsp/stm32/stm32f407-micu/project.uvprojx
  • bsp/stm32/stm32f407-micu/rtconfig.h

🏷️ Tag: bsp_stm32f407-micu

Reviewers: @Dailingxiang1

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-micu/.config
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/.mxproject
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/CubeMX_Config.ioc
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/main.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/main.c
  • bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
  • bsp/stm32/stm32f407-micu/board/Kconfig
  • bsp/stm32/stm32f407-micu/board/ports/SConscript
  • bsp/stm32/stm32f407-micu/board/ports/spi_flash_init.c
  • bsp/stm32/stm32f407-micu/project.uvoptx
  • bsp/stm32/stm32f407-micu/project.uvprojx
  • bsp/stm32/stm32f407-micu/rtconfig.h

📊 Current Review Status (Last Updated: 2025-12-11 19:17 CST)

  • ⌛ @Dailingxiang1 Pending Review
  • ⌛ @Liang1795 Pending Review
  • ⌛ @hamburger-os Pending Review
  • ⌛ @wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态 Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认 PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。 ℹ️ Refresh CI status operation requires repository Write permission.

github-actions[bot] avatar Nov 25 '25 13:11 github-actions[bot]

😃有什么问题请接着指出

Dailingxiang1 avatar Nov 30 '25 01:11 Dailingxiang1

SPI Flash宏定义关闭重新生成一下.config以及rtcobnfig.h，还有mdk文件同步一下，默认bsp保持最小系统即可，交给用户手动去开启

kurisaW avatar Nov 30 '25 10:11 kurisaW

最近有点忙，已修改> SPI Flash宏定义关闭重新生成一下.config以及rtcobnfig.h，还有mdk文件同步一下，默认bsp保持最小系统即可，交给用户手动去开启

Dailingxiang1 avatar Dec 11 '25 10:12 Dailingxiang1