rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

Fixes clock_gettime and rt_ktime_boottime_get_ns

Open lygstate opened this issue 3 months ago • 4 comments

拉取/合并请求描述:(PR description)

continue work of https://github.com/RT-Thread/rt-thread/pull/9008

Fixes overflow of clock_gettime rt_ktime_boottime_get_ns thoroughly

Currently the return value of clock_gettime and rt_ktime_boottime_get_ns are restricted by rt_ktime_cputimer_getres, as the value of rt_ktime_cputimer_getres are not exactly represent the frequency of the clock, directly using rt_ktime_cputimer_getfrq will ensure the return value of rt_ktime_boottime_get_ns be more exact. And also add function rt_muldiv_u64 rt_muldiv_u32 for not losing precision when convert between cputimer and hrtimer and nanoseconds.

Because rt_ktime_boottime_get_ns depends on rt_ktime_cputimer_getcnt and rt_ktime_cputimer_getcnt depends rt_tick_get So the rt_tick_t should be 64bit for long running program.

Use #if defined(ARCH_CPU_64BIT) is for future allow rt_tick_t can be 64bit on 32bit CPU.

Tick count should not be restricted to the CPU

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [x] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [x] 代码是高质量的 Code in this PR is of high quality
  • [ ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [ ] 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

lygstate avatar Sep 25 '25 17:09 lygstate

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流。 To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below.


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page 点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾) Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:rt_tick_t_64_bit
  • 设置PR number为 \ Set the PR number to:10749
  1. 等待工作流完成 | Wait for the workflow to complete 格式化后的代码将自动推送至你的分支。 The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 rt_tick_t_64_bit 分支,关联的 Pull Request 也会同步更新。 Once completed, commits will be pushed to the rt_tick_t_64_bit branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐 If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions[bot] avatar Sep 25 '25 17:09 github-actions[bot]

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/ktime/inc/ktime.h
  • components/drivers/ktime/src/aarch64/cputimer.c
  • components/drivers/ktime/src/boottime.c
  • components/drivers/ktime/src/cputimer.c
  • components/drivers/ktime/src/hrtimer.c
  • components/drivers/ktime/src/risc-v/virt64/cputimer.c
  • components/drivers/rtc/dev_soft_rtc.c
  • components/libc/compilers/common/ctime.c

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/compilers/common/ctime.c

🏷️ Tag: kernel

Reviewers: @GorrayLi @ReviewSun @hamburger-os @lianux-mm @wdfk-prog @xu18838022837

Changed Files (Click to expand)
  • src/rttypes.c

📊 Current Review Status (Last Updated: 2025-11-12 13:18 CST)

  • @GorrayLi Pending Review
  • @Maihuanyi Pending Review
  • @ReviewSun Pending Review
  • @hamburger-os Pending Review
  • @lianux-mm Pending Review
  • @mysterywolf Pending Review
  • @wdfk-prog Pending Review
  • @xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态 Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认 PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。 ℹ️ Refresh CI status operation requires repository Write permission.

github-actions[bot] avatar Sep 25 '25 17:09 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 27 '25 02:09 CLAassistant

@Rbb666 ping

lygstate avatar Oct 31 '25 09:10 lygstate